Alexey Serbin has posted comments on this change. Change subject: KUDU-1812: redact row contents from logs ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5555/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 1926: // Internal Kudu Note: This method must not be used in log messages because : // it contains sensitive predicate values. Use Scanner::Data::DebugString : // instead. nit: since it's 'doxygenized' comment, please make the new note to conform that style as well -- check for @note ... in this file for examples. http://gerrit.cloudera.org:8080/#/c/5555/1/src/kudu/client/write_op.h File src/kudu/client/write_op.h: PS1, Line 78: // Note for internal Kudu use: this method does *NOT* redact row values. The : // caller must check 'log_row_contents' themselves, if applicable. nit: since it's 'doxygenized' comment, please make the new note to conform that style as well -- check for @note ... in this file for examples. http://gerrit.cloudera.org:8080/#/c/5555/1/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: PS1, Line 461: // Note for internal Kudu use: this method does *NOT* redact row values. The : // caller must check 'log_row_contents' themselves, if applicable. nit: since it's 'doxygenized' comment, please make the new note to conform that style as well -- check for @note ... in this file for examples. http://gerrit.cloudera.org:8080/#/c/5555/1/src/kudu/common/schema.h File src/kudu/common/schema.h: PS1, Line 28: <gflags/gflags.h> I'm not sure this is needed in this file. If yes, then as a nit, please consider using <gflags/gflags_declare.h> instead. -- To view, visit http://gerrit.cloudera.org:8080/5555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b87a3065280116bb8af6f26f072dafdfd1ee077 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
