Dan Burkert has posted comments on this change. Change subject: KUDU-1812. Redact pretty-printed sensitive user data ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5555/2/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: Line 36: case RowOperationsPB::UNKNOWN: > Restore this comment. Done http://gerrit.cloudera.org:8080/#/c/5555/3/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: Line 48: return Substitute("SPLIT_ROW $0", split_row->ToString()); > From here down should use KUDU_DISABLE_REDACTION. Done http://gerrit.cloudera.org:8080/#/c/5555/3/src/kudu/tablet/transactions/write_transaction.cc File src/kudu/tablet/transactions/write_transaction.cc: Line 357: // NOTE: we'll eventually need to gate this by some flag if we want to avoid > Remove this. Done -- To view, visit http://gerrit.cloudera.org:8080/5555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b87a3065280116bb8af6f26f072dafdfd1ee077 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
