Alexey Serbin has posted comments on this change. Change subject: KUDU-1812: redact row contents from logs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5555/1/src/kudu/client/client.h File src/kudu/client/client.h: PS1, Line 1926: // Internal Kudu Note: This method must not be used in log messages because : // it contains sensitive predicate values. Use Scanner::Data::DebugString : // instead. > I made it with two slashes intentionally to avoid having it show up in the OK, I see now. As for formatting/documenting, there is an option to enclose that note into the @internal/@endinternal directives: http://www.doxygen.nl/manual/commands.html#cmdinternal As for the implementation, I don't have a good idea here. -- To view, visit http://gerrit.cloudera.org:8080/5555 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b87a3065280116bb8af6f26f072dafdfd1ee077 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
