Todd Lipcon has posted comments on this change. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5488/1/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: PS1, Line 891: this seems odd that the : // "latest observed" timestamp is one higher than the thing we wrote > the latest observed timestamp is read from the clock just before the scanne you mean from the write response, right? Is that a bug or a feature? i.e I would sort of expect that the "latest observed" would be exactly my timestamp, because my write didn't observe the timestamp after it. For example, if the timestamp after it was used to UPSERT on top of my INSERT, then my INSERT didn't "observe" the UPSERT (it would have failed had it observed it) -- To view, visit http://gerrit.cloudera.org:8080/5488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7d44f6e2fe4d3cae03e0024c70e9f2ae84b614c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
