Todd Lipcon has posted comments on this change. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5488/1/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: PS1, Line 891: this seems odd that the : // "latest observed" timestamp is one higher than the thing we wrote > sorry, I think I described the problem backwards. I traced through the code a bit more and decided this is an off-by-one bug in MvccManager. Filed KUDU-1813 -- To view, visit http://gerrit.cloudera.org:8080/5488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7d44f6e2fe4d3cae03e0024c70e9f2ae84b614c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
