Todd Lipcon has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5619/1//COMMIT_MSG Commit Message: Line 7: EMC: Don't reuse data dir for log dir Looking at the current code, I don't see it using the same dir for the data dir and log dir. Isn't it using test/ts-0/ for data and test/ts-0-logs/ for logs? The only test I can find that actually disables the default ExternalMiniClusterOptions::logtostderr is log_rolling-itest, and when I run it, I see: todd@todd-ThinkPad-T540p:~/git/kudu$ ls -l /tmp/kudutest-1000/log-rolling-itest.LogRollingITest.TestLogCleanupOnStartup.1483652421039782-28949/minicluster-data/ total 8 drwxr-xr-x 6 todd todd 4096 Jan 5 13:40 master-0 drwxr-xr-x 2 todd todd 4096 Jan 5 13:40 master-0-logs -- To view, visit http://gerrit.cloudera.org:8080/5619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba23c429989df524da51eb012a491766df06e955 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
