Todd Lipcon has posted comments on this change. Change subject: EMC: Don't reuse data dir for log dir ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5619/1/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: Line 653: RETURN_NOT_OK(env_util::CreateDirsRecursively(env, log_dir_)); did you only need CreateDirsRecursively for the purpose of this change? If so, why not just keep the old paths (ts-0 and ts-0-logs rather than ts-0/data and ts-0/logs)? Seems simpler than having to implement that utility function just for test purposes. http://gerrit.cloudera.org:8080/#/c/5619/1/src/kudu/integration-tests/external_mini_cluster.h File src/kudu/integration-tests/external_mini_cluster.h: PS1, Line 404: const no need to return a const primitive -- To view, visit http://gerrit.cloudera.org:8080/5619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba23c429989df524da51eb012a491766df06e955 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
