Mike Percy has posted comments on this change. Change subject: env_util: Implement CreateDirsRecursively() ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5618/2/src/kudu/util/env_util-test.cc File src/kudu/util/env_util-test.cc: PS2, Line 90: JoinPathSegments(JoinPathSegments(JoinPathSegments(test_dir_, "x"), "y"), "z") > again on the portability thing, I'd personally rather read "x/y/z" since we Done http://gerrit.cloudera.org:8080/#/c/5618/2/src/kudu/util/env_util.cc File src/kudu/util/env_util.cc: PS2, Line 195: = "" > isn't this redundant? the default constructor is already "" Done Line 200: if (s.ok() && is_dir) continue; > If you're aiming for mkdir -p semantics, it should be ok for one of the pat Well spotted. Rather than jumping around using chdir(), I used realpath() via Env::Canonicalize() when detecting that a file exists in a subpath but it's not a normal directory. I think that's probably alright because it would be rare to have a very long path composed entirely of symlinks. -- To view, visit http://gerrit.cloudera.org:8080/5618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia664708a09493923abbf2ff4e56e3d49c62cf97e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
