Dinesh Bhat has posted comments on this change. Change subject: Add some path / env related helper functions ......................................................................
Patch Set 3: -Code-Review (1 comment) http://gerrit.cloudera.org:8080/#/c/5618/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 896: unique_ptr<char, FreeDeleter> wd(getcwd(NULL, 0)); > Please ask a Kudu macOS-based dev to build this before merging. Done; compiles fine on macOS. -- To view, visit http://gerrit.cloudera.org:8080/5618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia664708a09493923abbf2ff4e56e3d49c62cf97e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
