Todd Lipcon has posted comments on this change. Change subject: env_util: Implement CreateDirsRecursively() ......................................................................
Patch Set 2: (2 comments) general note: while I like fine-grained patches, for these simple utility functions I typically find them easier to review when they come with their usage context (eg this could be merged with the chdir/cwd patch, the split paths, the isrelative, etc) http://gerrit.cloudera.org:8080/#/c/5618/2/src/kudu/util/env_util-test.cc File src/kudu/util/env_util-test.cc: PS2, Line 90: JoinPathSegments(JoinPathSegments(JoinPathSegments(test_dir_, "x"), "y"), "z") again on the portability thing, I'd personally rather read "x/y/z" since we are so far from windows support and it's hard to see what's going on here. (same above) http://gerrit.cloudera.org:8080/#/c/5618/2/src/kudu/util/env_util.cc File src/kudu/util/env_util.cc: PS2, Line 195: = "" isn't this redundant? the default constructor is already "" -- To view, visit http://gerrit.cloudera.org:8080/5618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia664708a09493923abbf2ff4e56e3d49c62cf97e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
