Dan Burkert has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5692/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: PS1, Line 72: Trailing whitespace will be trimmed " : "before it is used to decrypt the private key. I'm worried this is going to result in issues with randomly generated passwords containing legitimate whitespace characters. Is there a strong reason to do the stripping? I don't thing the behavior of 'echo' is compelling enough. -- To view, visit http://gerrit.cloudera.org:8080/5692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedf60251d9212c0c135db00902c00119c9d8849c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
