Todd Lipcon has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5692/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: PS1, Line 72: Trailing whitespace will be trimmed " : "before it is used to decrypt the private key. > > I think the likelihood is that any user-provided script is going to havin Sorry, I mean that any user-provided script is going to output the password with a trailing newline. At least I imagine if I were the one implementing such a script I'd probably end up using 'echo' or python 'print' or something else that prints a newline by default. Moreover, for compatibility with other components I think we have to do this. For example, Hue strips newlines and their example emits them: http://gethue.com/storing-passwords-in-script-rather-than-hue-ini-files/ -- To view, visit http://gerrit.cloudera.org:8080/5692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedf60251d9212c0c135db00902c00119c9d8849c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
