Dan Burkert has posted comments on this change. Change subject: rpc: allow using encrypted private key for SSL ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5692/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: PS1, Line 72: Trailing whitespace will be trimmed " : "before it is used to decrypt the private key. > I think the likelihood is that any user-provided script is going to having > I think the likelihood is that any user-provided script is going to having > trailing newlines. Isn't it the output of the command which is being stripped? The issue here is that someone who is randomly generating the password now has to throw out passwords with trailing newlines or whitespace. -- To view, visit http://gerrit.cloudera.org:8080/5692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iedf60251d9212c0c135db00902c00119c9d8849c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
