Dan Burkert has posted comments on this change. Change subject: Add tls_common module ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 37: tls_common.cc) > would be nice if we could standardize on "SSL" vs "TLS". just a note, not a I agree, and plan to standardize on TLS. I didn't want to rename during the move, though. http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/tls_common.h File src/kudu/security/tls_common.h: Line 30: // Initializes static state required by the OpenSSL library. > I'd expect this to be called InitOpenSSL or somesuch, and be in a different Sure, I'll rename this to openssl_util.h -- To view, visit http://gerrit.cloudera.org:8080/5704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb8bc2fb4153eff7adf896e43a979783de6f4b8 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
