Alexey Serbin has posted comments on this change. Change subject: Add openssl_util ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 37: tls_common.cc) > I agree, and plan to standardize on TLS. I didn't want to rename during th I can do that in my subsequent patch, if you are not planning to have a separate one dedicated for that update. http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/tls_common.cc File src/kudu/security/tls_common.cc: Line 93: char buf[256]; > is 256 always enough for the error messages we expect? In the OpenSSL library they usually use 128. The long things might be filenames, etc., but those are not included into the message, coming separately. -- To view, visit http://gerrit.cloudera.org:8080/5704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb8bc2fb4153eff7adf896e43a979783de6f4b8 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
