Todd Lipcon has posted comments on this change. Change subject: Add tls_common module ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 37: tls_common.cc) would be nice if we could standardize on "SSL" vs "TLS". just a note, not a blocker for this patch. http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/tls_common.cc File src/kudu/security/tls_common.cc: Line 93: char buf[256]; is 256 always enough for the error messages we expect? Line 99: serr << " "; weird to end in a space http://gerrit.cloudera.org:8080/#/c/5704/6/src/kudu/security/tls_common.h File src/kudu/security/tls_common.h: Line 30: // Initializes static state required by the OpenSSL library. I'd expect this to be called InitOpenSSL or somesuch, and be in a differently named .cc file. It's not TLS-only, right? ie even if we just want to play with certs, we'd need to call this. Line 36: std::string GetOpenSSLErrors(); same. Maybe this file should be util.h or somesuch? -- To view, visit http://gerrit.cloudera.org:8080/5704 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb8bc2fb4153eff7adf896e43a979783de6f4b8 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
