Dan Burkert has posted comments on this change. Change subject: Move SSLFactory and SSLSocket to the security module ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/5703/5//COMMIT_MSG Commit Message: PS5, Line 9: Soon these classes will rely on the security module > Is that about RPC-related ones? If so, consider re-phrasing a bit. No, it's referring to SSLFactory and SSLSocket. http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/ssl_socket.h File src/kudu/security/ssl_socket.h: PS5, Line 17: #ifndef KUDU_UTIL_NET_SSL_SOCKET_H : #define KUDU_UTIL_NET_SSL_SOCKET_H > Since you are replacing include guards with pragma once, consider doing thi Done http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/x509_check_host.h File src/kudu/security/x509_check_host.h: PS5, Line 12: #ifndef X509_CHECK_HOST_H : #define X509_CHECK_HOST_H > Is this intentionally set to X509_CHECK_HOST_H to be the same as the guard Yes, according to Todd it is. -- To view, visit http://gerrit.cloudera.org:8080/5703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
