Todd Lipcon has posted comments on this change. Change subject: Move SSLFactory and SSLSocket to the security module ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5703/4/src/kudu/security/x509_check_host.cc File src/kudu/security/x509_check_host.cc: Line 14: #include "kudu/security/x509_check_host.h" I think this was purposefully included after the openssl library, and used the same include guards, so that it won't double-declare it on versions of ssl which supported x509_check_host -- To view, visit http://gerrit.cloudera.org:8080/5703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
