Alexey Serbin has posted comments on this change. Change subject: Move SSLFactory and SSLSocket to the security module ......................................................................
Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5703/5/src/kudu/security/x509_check_host.h File src/kudu/security/x509_check_host.h: PS5, Line 12: #ifndef X509_CHECK_HOST_H : #define X509_CHECK_HOST_H > Yes, according to Todd it is. After some consideration I don't think it's relevant: corresponding .cc file is not compiled at all for newer version of the SSL library, so this include guard can be anything. But it's not crucial. -- To view, visit http://gerrit.cloudera.org:8080/5703 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100966cfd51435e2954459fce79baa7cf6da4dcb Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
