Adar Dembo has posted comments on this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support ......................................................................
Patch Set 2: (1 comment) Hmm. How does Impala consume kudu_util. Does it do so without building the thirdparty tree? If not, I don't understand how this simplifies anything, because you'd still be _building_ nvml. As an aside, we should really start documenting our CMake options via option(). Not your problem (and not in scope for this change) though. http://gerrit.cloudera.org:8080/#/c/5712/2/src/kudu/util/cache.cc File src/kudu/util/cache.cc: Line 503: #if !defined(__APPLE__) && !defined(NO_NVM_SUPPORT) __APPLE__ implies NO_NVM_SUPPORT given your changes to CMakeLists.txt, right? So the first case can be removed? -- To view, visit http://gerrit.cloudera.org:8080/5712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib915b0c9e08d0e3eae0bf778dca6f6138e83bc21 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
