Adar Dembo has posted comments on this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support ......................................................................
Patch Set 2: > We consume kudu_util by dropping it in our source dir, and building > it like it were another local library. This patch > https://github.com/henryr/Impala/commit/5958d6e3211e113fd5e42562ef27cfae021f5f23 > might shed more light on the situation. > > We don't consume thirdparty at all. Any new dependencies (libev, > crcutil, proto*) have gone into our toolchain. Hence, with this > change, we don't touch nvm libraries at all. Makes sense, thanks. Will +2 once you address that one issue in cache.cc. -- To view, visit http://gerrit.cloudera.org:8080/5712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib915b0c9e08d0e3eae0bf778dca6f6138e83bc21 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
