Adar Dembo has posted comments on this change. Change subject: Add NO_NVM_SUPPORT cmake var to suppress linking or compiling with nvm support ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5712/3/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: Line 236: target_compile_definitions(kudu_util PRIVATE On second thought, could you move this to the main CMakeLists.txt and set it up via add_definitions(), so it'll apply universally? That way if something like "#ifndef NO_NVM_SUPPORT" finds its way into some code outside of kudu_util, we won't have to worry about accidentally forgetting to expand the scope of this statement. -- To view, visit http://gerrit.cloudera.org:8080/5712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib915b0c9e08d0e3eae0bf778dca6f6138e83bc21 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
