Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ......................................................................
Patch Set 1: > I'm pretty sure we don't want this limitation, see > https://github.com/cloudera/kudu/commit/7d57b8b9204a0b170fc204cb7aaa98ad995cf635#diff-933a1ca025bc6af95c770d34958fe46a > > I wonder why the unit tests are still passing though. Thanks for the comments. It seems now java client relies on the server side (wire_protocol) to check if the schema is correct for operations, e.g. row insertion. For example, in TestScannerMultiTablet, if `val` column is added before `key2` at getSchema method, the test will fail during `setUpBeforeClass` when session apply a new row. The java client receives a NonRecoverableException saying "Got out-of-order key column ..." I think client side check is good as it can prevent the bad operation sent to the server. If schema is not the right place to add the check, how about doing the check within operation classes? -- To view, visit http://gerrit.cloudera.org:8080/5723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca2a572801c964331ed65c630db28436fcaf86a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Jun He <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
