Jun He has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first ......................................................................
Patch Set 2: > (1 comment) > > Jun, what motivated you to make this change in the first place? It > seems that the master would just reply with the same error you're > adding in this patch, which is kind of duplicated code. Hi Jean-Daniel, thanks for the code review. I am thinking it is better to do the local client side validation before sending a request to the network. It might reduce some traffic to Kudu servers. As this is only needed in the createTable request, it is unlikely Kudu servers receive a huge amount of createTable requests. It makes sense to just let servers to handle it in this case. I will remove the check code in AsyncKuduClient, clean up Schema java doc, and remove the extra unit test. -- To view, visit http://gerrit.cloudera.org:8080/5723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ca2a572801c964331ed65c630db28436fcaf86a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jun He <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Jun He <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
