Jun He has posted comments on this change.

Change subject: KUDU-1831. Java client does not check if the primary key 
columns are specified first
......................................................................


Patch Set 2:

Thanks for the discussion. 

Remove the new code from Schema class. Cleaned up the Javadoc. Added a check in 
createTable method to make sure the table schema is valid before sending rpc 
request. Added unit tests.

-- 
To view, visit http://gerrit.cloudera.org:8080/5723
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca2a572801c964331ed65c630db28436fcaf86a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jun He <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Jun He <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to