Adar Dembo has posted comments on this change. Change subject: Move 'master_rpc.h' into the client/ module ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5864/1//COMMIT_MSG Commit Message: Line 7: Move 'master_rpc.h' into the client/ module Nit: 'master_rpc.ch' or just 'master_rpc' PS1, Line 10: Even though the recipient of the : RPCs implemented here is the master, it doesn't make much sense to put : it in the master/ module since the master never uses this code. It made more sense back when tserver/heartbeater.cc used it to find the leader master; it was a decent way to consume that code without consuming the entire client module. But I agree, it's poorly placed right now. -- To view, visit http://gerrit.cloudera.org:8080/5864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3a1db6aeb5326e6dfb9986b08949fa349b5f74d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
