Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5864
to review the following change.
Change subject: Move 'master_rpc.h' into the client/ module
......................................................................
Move 'master_rpc.h' into the client/ module
This file had a couple of classes which were in fact only used by the
client and by the ExternalMiniCluster. Even though the recipient of the
RPCs implemented here is the master, it doesn't make much sense to put
it in the master/ module since the master never uses this code.
This patch moves it into client/ and puts it in the
kudu::client::internal namespace. Additionally, one of the two classes
here is only used internally by the other, so I moved that into an
anonymous namespace in the .cc file.
This is in preparation for some surgery on this file to convert it into
more of a "connect to cluster" type RPC which will also be responsible
for grabbing an authentication token, the master CA list, etc.
Change-Id: Ic3a1db6aeb5326e6dfb9986b08949fa349b5f74d
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
R src/kudu/client/master_rpc.cc
R src/kudu/client/master_rpc.h
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/master/CMakeLists.txt
M src/kudu/tserver/CMakeLists.txt
M src/kudu/tserver/heartbeater.cc
9 files changed, 66 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/5864/1
--
To view, visit http://gerrit.cloudera.org:8080/5864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3a1db6aeb5326e6dfb9986b08949fa349b5f74d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
