Todd Lipcon has posted comments on this change. Change subject: Move 'master_rpc.h' into the client/ module ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5864/1/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 66: using master::GetTabletLocationsRequestPB; > warning: using decl 'GetTabletLocationsRequestPB' is unused [misc-unused-us I think this is a false positive (it's used in a template instantiation, and clang doesn't include those in the AST) Line 87: using internal::GetTableSchemaRpc; > warning: using decl 'GetTableSchemaRpc' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/5864/1/src/kudu/client/master_rpc.cc File src/kudu/client/master_rpc.cc: Line 153: : Rpc(std::move(deadline), std::move(messenger)), > warning: std::move of the variable of a trivially-copyable type has no effe these are all in just moved code, so going to attack them all in a separate patch -- To view, visit http://gerrit.cloudera.org:8080/5864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3a1db6aeb5326e6dfb9986b08949fa349b5f74d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
