Alexey Serbin has posted comments on this change. Change subject: WIP: issue authentication tokens and CA certs to clients ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5871/1/src/kudu/master/authn_token_manager.cc File src/kudu/master/authn_token_manager.cc: Line 22: nit: consider adding <gflags/gflags.h> http://gerrit.cloudera.org:8080/#/c/5871/1/src/kudu/master/authn_token_manager.h File src/kudu/master/authn_token_manager.h: PS1, Line 23: #include "kudu/util/status.h" nit: consider forward-declaring Status instead of including this header file. http://gerrit.cloudera.org:8080/#/c/5871/1/src/kudu/master/master.proto File src/kudu/master/master.proto: PS1, Line 587: server client? http://gerrit.cloudera.org:8080/#/c/5871/1/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: PS1, Line 368: and not by another token. Is it already possible to get here authenticating by an authn token? -- To view, visit http://gerrit.cloudera.org:8080/5871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5969b8e125633b3b14364b98c0d0a992b162f302 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
