Dan Burkert has posted comments on this change. Change subject: master: issue authentication tokens and CA certs to clients ......................................................................
Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5871/4/src/kudu/master/authn_token_manager.h File src/kudu/master/authn_token_manager.h: Line 25: class Status; Don't you need the full type to have it in the return position? http://gerrit.cloudera.org:8080/#/c/5871/2/src/kudu/master/master.proto File src/kudu/master/master.proto: Line 563: repeated bytes ca_cert_der = 3; > I figured that if we make it repeated now, and have the client add all retu yes, sounds good. -- To view, visit http://gerrit.cloudera.org:8080/5871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5969b8e125633b3b14364b98c0d0a992b162f302 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
