Alexey Serbin has posted comments on this change. Change subject: master: issue authentication tokens and CA certs to clients ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5871/4/src/kudu/master/authn_token_manager.h File src/kudu/master/authn_token_manager.h: Line 25: class Status; > Everything I thought I knew about C++ headers is wrong. Yep, for return and for parameters passed by pointer and reference you don't need the full type info in the header file. http://gerrit.cloudera.org:8080/#/c/5871/4/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: PS4, Line 1290: TEST_F(MasterTest, TestConnectToMaster) This test runs after the master is up and loaded its CA cert info. From the other side, do we expect to have any issues if a client sends a request while the master is booting up? Does it make sense to add a test for that as well or it's clear it should not be an issue for the client? http://gerrit.cloudera.org:8080/#/c/5871/4/src/kudu/master/master_cert_authority.h File src/kudu/master/master_cert_authority.h: PS4, Line 71: std::string const string& ? http://gerrit.cloudera.org:8080/#/c/5871/4/src/kudu/security/token.proto File src/kudu/security/token.proto: PS4, Line 24: optional string username = 1; Does it make sense to redact this as well? -- To view, visit http://gerrit.cloudera.org:8080/5871 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5969b8e125633b3b14364b98c0d0a992b162f302 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
