Todd Lipcon has posted comments on this change. Change subject: Use an outbound Encoder, add a test for Negotiator ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5947/1/java/kudu-client/src/main/java/org/apache/kudu/client/RpcOutboundMessage.java File java/kudu-client/src/main/java/org/apache/kudu/client/RpcOutboundMessage.java: Line 1: package org.apache.kudu.client; > License. Done Line 11: class RpcOutboundMessage { > Doc and InterfaceAudience Added doc. Don't need interface audience since it's not public. Line 12: > Cleanup here and below. Done http://gerrit.cloudera.org:8080/#/c/5947/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java: PS1, Line 67: -33 > Use the relevant constant here and below? Done -- To view, visit http://gerrit.cloudera.org:8080/5947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75419b8c38dea9226ccac6a49ea00e17c74038f6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
