Todd Lipcon has submitted this change and it was merged. Change subject: java: use an outbound Encoder, add a test for Negotiator ......................................................................
java: use an outbound Encoder, add a test for Negotiator This adds an Encoder to the front of the Netty pipeline, so that we can send 'RpcOutboundMessage' objects instead of raw ChannelBuffers. This doesn't really have any major effect, except that it makes testing a bit easier -- we can stick parts of the pipeline in an Embedder and more easily inspect the messages they are sending. As proof of this, this patch adds a basic test for the Negotiator. Change-Id: I75419b8c38dea9226ccac6a49ea00e17c74038f6 Reviewed-on: http://gerrit.cloudera.org:8080/5947 Reviewed-by: Jean-Daniel Cryans <[email protected]> Tested-by: Kudu Jenkins --- M java/kudu-client/src/main/java/org/apache/kudu/client/CallResponse.java M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java A java/kudu-client/src/main/java/org/apache/kudu/client/RpcOutboundMessage.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java 6 files changed, 182 insertions(+), 10 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5947 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75419b8c38dea9226ccac6a49ea00e17c74038f6 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
