Todd Lipcon has posted comments on this change. Change subject: WIP: [security] Negotiate authentication type during RPC setup ......................................................................
Patch Set 1: (2 comments) just did a quick once over. looks like a reasonable direction http://gerrit.cloudera.org:8080/#/c/5988/1/src/kudu/rpc/client_negotiation.cc File src/kudu/rpc/client_negotiation.cc: Line 174: // When using SASL, we don't verify the server's certificate. Instead, we worth a rewrite of this comment block http://gerrit.cloudera.org:8080/#/c/5988/1/src/kudu/rpc/sasl_common.h File src/kudu/rpc/sasl_common.h: Line 44: // another grab bag class which is used by client and server negotiation. negotiation.h? or just use the enum defined in the protobuf? -- To view, visit http://gerrit.cloudera.org:8080/5988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed9a1a474990dbfe9b71173adffdec95ec02b6c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
