Alexey Serbin has posted comments on this change. Change subject: [security] Negotiate authentication type during RPC setup ......................................................................
Patch Set 3: (3 comments) Overall looks good, just a couple of nits. Will try to do another pass later tonight. If you get +2 sooner, don't wait for my review -- I don't want to block you on this. http://gerrit.cloudera.org:8080/#/c/5988/3/src/kudu/rpc/rpc_header.proto File src/kudu/rpc/rpc_header.proto: PS3, Line 174: authn_token I see there is REDACT attribute for the 'channel_bindings' field. Consider adding REDACT = true attribute for this field as well. http://gerrit.cloudera.org:8080/#/c/5988/3/src/kudu/security/token_verifier.cc File src/kudu/security/token_verifier.cc: PS3, Line 86: TokenPB* token For use-cases when callers do not need the token (the end of the chain), consider making it possible to pass nullptr here. Passing nullptr would mean the caller is not interested in getting the deserialized token. http://gerrit.cloudera.org:8080/#/c/5988/3/src/kudu/tserver/heartbeater.cc File src/kudu/tserver/heartbeater.cc: PS3, Line 448: nit: formatting mis-alignment. -- To view, visit http://gerrit.cloudera.org:8080/5988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed9a1a474990dbfe9b71173adffdec95ec02b6c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
