Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/5908/7/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: Line 508: } else { > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/5908/7/src/kudu/rpc/inbound_call.cc File src/kudu/rpc/inbound_call.cc: Line 36: using google::protobuf::Message; > warning: using decl 'Message' is unused [misc-unused-using-decls] Done Line 38: using std::shared_ptr; > warning: using decl 'shared_ptr' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/5908/7/src/kudu/rpc/rpc_sidecar.h File src/kudu/rpc/rpc_sidecar.h: Line 54: // TODO: Consider a vector instead here if there's no perf. impact. > warning: missing username/bug in TODO [google-readability-todo] Done -- To view, visit http://gerrit.cloudera.org:8080/5908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d709edb2a22dc983f51b69d7660a39e8d8d6a09 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
