Todd Lipcon has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars ......................................................................
Patch Set 11: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5908/8/src/kudu/rpc/rpc_sidecar.cc File src/kudu/rpc/rpc_sidecar.cc: PS8, Line 83: that at offset $1.", i, cu > Still tricky because of the change to uint64_t for offsets - I changed the yea, we have lots of 64-bit assumptions, would be a hard project to port to 32-bit -- To view, visit http://gerrit.cloudera.org:8080/5908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d709edb2a22dc983f51b69d7660a39e8d8d6a09 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
