Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1866: Add request-side sidecars ......................................................................
KUDU-1866: Add request-side sidecars This patch adds sidecars to client requests. Using the same mechanism as on the response-side, clients may attach slices to outbound requests which do not pass through a serialization or copy before being pushed to the network socket. On the server side, these sidecars may be read directly from the underlying byte stream with the interposition of a Protobuf wrapper. The sidecars may be added to a request via RpcController and retrieved via RpcContext (i.e. the reverse of the existing response-side interface). This patch adds a few tests to rpc-test, and all rpc-test tests pass. Change-Id: I3d709edb2a22dc983f51b69d7660a39e8d8d6a09 Reviewed-on: http://gerrit.cloudera.org:8080/5908 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/client/scanner-internal.cc M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/inbound_call.h M src/kudu/rpc/outbound_call.cc M src/kudu/rpc/outbound_call.h M src/kudu/rpc/proxy.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc-test.cc M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/rpc_controller.cc M src/kudu/rpc/rpc_controller.h M src/kudu/rpc/rpc_header.proto A src/kudu/rpc/rpc_sidecar.cc M src/kudu/rpc/rpc_sidecar.h M src/kudu/rpc/rtest.proto M src/kudu/rpc/transfer.h M src/kudu/tserver/tablet_server-test-base.h M src/kudu/tserver/tablet_service.cc 20 files changed, 429 insertions(+), 126 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/5908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d709edb2a22dc983f51b69d7660a39e8d8d6a09 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
