Todd Lipcon has posted comments on this change. Change subject: [security] Negotiate authentication type during RPC setup ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5988/5/src/kudu/rpc/server_negotiation.h File src/kudu/rpc/server_negotiation.h: Line 79: return negotiated_authn_; > woops, yep I forgot to initialize. I don't get why that's not a warning. seems like maybe we could get this by adding -Wmissing-field-initializers in clang? some people complain there are a lot of false positives with it though, given it's not too uncommon to have fields left uninitialized and initted by a Init() method -- To view, visit http://gerrit.cloudera.org:8080/5988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ed9a1a474990dbfe9b71173adffdec95ec02b6c Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
