Adar Dembo has posted comments on this change. Change subject: KUDU-1844: /varz should not expose potentially sensitive configs ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/6043/1/src/kudu/server/default-path-handlers.cc File src/kudu/server/default-path-handlers.cc: Line 46: using boost::replace_all; > Not quite follow the comments? What this means is that there's no reference to replace_all anywhere in this file, so this line can be removed. http://gerrit.cloudera.org:8080/#/c/6043/2/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: Line 31: #include <kudu/util/logging.h> This should be a "project" include (with double quotes) rather than a "system" include (with triangular brackets). http://gerrit.cloudera.org:8080/#/c/6043/1/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 111: DEFINE_bool(redact_sensitive_flags, true, > I agree we may want to make it more general for different redaction purpose Sure, I'm fine with deferring that to another commit. http://gerrit.cloudera.org:8080/#/c/6043/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: Line 453: // Redact the flags tagged as sensitive, if --redact_sensitive_flags OK, now that you're doing the same thing in two places (here and CommandlineFlagsIntoString()), there is value in decomposing a helper function that'll do it for you. -- To view, visit http://gerrit.cloudera.org:8080/6043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7661e0409c79559f22b07e7c12737e804544186b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
