Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1844: /varz should not expose potentially sensitive configs ......................................................................
KUDU-1844: /varz should not expose potentially sensitive configs This adds a new flag tag 'sensitive' and a new flag --redact_sensitive_flags. If a flag is tagged as 'sensitive', and --redact_sensitive_flags is set to true, then its value would be redacted as '<redacted>' when using /varz to dump the flags. So that it would not be exposed via WebUI. Example output with flags redacted: --test_sensitive_flag=<redacted> Change-Id: I7661e0409c79559f22b07e7c12737e804544186b Reviewed-on: http://gerrit.cloudera.org:8080/6043 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/server/default-path-handlers.cc M src/kudu/server/webserver-test.cc M src/kudu/util/flag_tags-test.cc M src/kudu/util/flag_tags.h M src/kudu/util/flags-test.cc M src/kudu/util/flags.cc M src/kudu/util/flags.h M src/kudu/util/logging.cc M src/kudu/util/logging.h 9 files changed, 95 insertions(+), 12 deletions(-) Approvals: Adar Dembo: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/6043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7661e0409c79559f22b07e7c12737e804544186b Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
