Adar Dembo has posted comments on this change. Change subject: KUDU-1844: /varz should not expose potentially sensitive configs ......................................................................
Patch Set 3: Code-Review+2 Verified+1 (1 comment) Yeah, that's a known flaky test. I can't imagine how your changes would have caused it. http://gerrit.cloudera.org:8080/#/c/6043/1/src/kudu/server/default-path-handlers.cc File src/kudu/server/default-path-handlers.cc: Line 46: using boost::replace_all; > Hmm, but I saw a reference of replace_all at line 137? If I remove it, ther Oh, that is odd. We've seen false positives before; may want to tell Todd about it since he's been tweaking the clang-tidy configuration. -- To view, visit http://gerrit.cloudera.org:8080/6043 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7661e0409c79559f22b07e7c12737e804544186b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
