Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog ......................................................................
Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/5930/14/src/kudu/master/master.h File src/kudu/master/master.h: Line 132: std::unique_ptr<security::TokenSigner> token_signer_; Checkout server_base.h, it's grown a TokenVerifier field. In the master, we'll want to use the TokenVerifier internal to this TokenSigner, while on the tablet server, we'll want to use a standalone one. Not sure the best way to do that, but it needs to be solved, otherwise the RPC system on the master won't be able to verify tokens. -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2417e2ccba6a1114db366b2f642f95362bf479c Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
