Alexey Serbin has posted comments on this change. Change subject: [security] load/store public TSK in the system table ......................................................................
Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/5935/14/src/kudu/integration-tests/token_signer-itest.cc File src/kudu/integration-tests/token_signer-itest.cc: Line 68: virtual void SetUp() OVERRIDE { > void SetUp() override { Done http://gerrit.cloudera.org:8080/#/c/5935/14/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS14, Line 324: Public > Should this be private key now? Done http://gerrit.cloudera.org:8080/#/c/5935/13/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: PS13, Line 92: // Length of the TSK entry identifier in the system catalog: all keys have : // the same length and are string representation of a number in decimal : // notation padded with zeroes in the beginning. This is to have natural : // ordering of the records while doing scan of TSK entries. : static const int kSysTskEntryKeySize = 20; > Agreed, this could easily use the key encoder / decoder to do this instead Done PS13, Line 92: // Length of the TSK entry identifier in the system catalog: all keys have : // the same length and are string representation of a number in decimal : // notation padded with zeroes in the beginning. This is to have natural : // ordering of the records while doing scan of TSK entries. : static const int kSysTskEntryKeySize = 20; > It has the added benefit of handling negatives correctly, and allowing us t Done -- To view, visit http://gerrit.cloudera.org:8080/5935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie91d4129bda0ca49e81988c28385895a2abcd201 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
