Todd Lipcon has posted comments on this change. Change subject: [security] load/store public TSK in the system table ......................................................................
Patch Set 23: (2 comments) I took the liberty of updating Alexey's patch to fix my two comments. Haven't done a full re-review, just wanted to fix these as they were blocking my work on the Java side. http://gerrit.cloudera.org:8080/#/c/5935/22/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 442: { > this lock is now being held while in Wait() which isn't desirable done PS22, Line 477: "aborting the current task: " << s.ToString(); : } > isn't this now breaking out of the whole loop, which would break background done -- To view, visit http://gerrit.cloudera.org:8080/5935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie91d4129bda0ca49e81988c28385895a2abcd201 Gerrit-PatchSet: 23 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
