Todd Lipcon has posted comments on this change. Change subject: [security] load/store public TSK in the system table ......................................................................
Patch Set 18: (2 comments) Didn't look through the whole patch but spotted some issues http://gerrit.cloudera.org:8080/#/c/5935/22/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 442: CatalogManager::ScopedLeaderSharedLock l(catalog_manager_); this lock is now being held while in Wait() which isn't desirable PS22, Line 477: // skip further actions on this iteration : break; isn't this now breaking out of the whole loop, which would break background tasks from futher progress? -- To view, visit http://gerrit.cloudera.org:8080/5935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie91d4129bda0ca49e81988c28385895a2abcd201 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
