Todd Lipcon has posted comments on this change. Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6158/1/src/kudu/util/logging.h File src/kudu/util/logging.h: PS1, Line 70: KUDU_MAYBE_REDACT_IF > Wouldn't "KUDU_REDACT_IF" be more idiomatic? I'm thinking of LOG vs. LOG_IF yea, I was worried though that that would sound like "unconditionally redact if the condition is true", whereas this still respects the global redaction flags. -- To view, visit http://gerrit.cloudera.org:8080/6158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I506b3710d2b50ec7a8947c49ec208eb4b53b63ea Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
