Todd Lipcon has posted comments on this change.

Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6158/1/src/kudu/util/jsonwriter_test.proto
File src/kudu/util/jsonwriter_test.proto:

Line 73:   repeated   string repeated_redacted_string = 46 [ (kudu.REDACT) = 
true ];
> Why not have repeated_redacted_bytes here?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6158
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I506b3710d2b50ec7a8947c49ec208eb4b53b63ea
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to