Alexey Serbin has posted comments on this change. Change subject: Fix security tests on macOS ......................................................................
Patch Set 1: (2 comments) This looks much cleaner than the original approach with separate flags for squeasel and libcurl. http://gerrit.cloudera.org:8080/#/c/6176/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: PS1, Line 169: brew nit: Homebrew ? PS1, Line 171: brew_openssl_include_dir Looks like a typo: in the line above and below the variable is named 'brew_openssl_dir' -- To view, visit http://gerrit.cloudera.org:8080/6176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ff10fa47cb7b8ec6f927619e1420fa5e81a7f20 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
