Dan Burkert has posted comments on this change. Change subject: Fix security tests on macOS ......................................................................
Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6176/2/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 388: } > Can you move this higher up so it's part of the existing anonymous namespac Done Line 400: KRB5_RETURN_NOT_OK_PREPEND(krb5_parse_name(g_krb5_ctx, principal->c_str(), &princ), > Is there an off-by-one error here? It looks like we're OK with username.len Done http://gerrit.cloudera.org:8080/#/c/6176/3/src/kudu/security/init.cc File src/kudu/security/init.cc: PS3, Line 379: > Nit: 1 > Done http://gerrit.cloudera.org:8080/#/c/6176/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: PS1, Line 169: Home > nit: Homebrew ? Done PS1, Line 171: homebrew_openssl_dir ]; > Looks like a typo: in the line above and below the variable is named 'brew_ Done -- To view, visit http://gerrit.cloudera.org:8080/6176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ff10fa47cb7b8ec6f927619e1420fa5e81a7f20 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
